CLOUDSTACK-10233: use namespace in Libvirt domain metadata.#2410
CLOUDSTACK-10233: use namespace in Libvirt domain metadata.#2410yadvr merged 1 commit intoapache:4.11from
Conversation
The documentation of Libvirt specifies the requirement of using an XML namespace, when having metadata in the Domain XML. The Nuage extenstion metadata was not adhering to this specification, and the lastest Libvirt version ignores it in that case.
krissterckx
left a comment
There was a problem hiding this comment.
Proved to work fine with the specified libvirt version.
LGTM
smeetsr
left a comment
There was a problem hiding this comment.
LGTM, verified on top of RHEL7.2 & RHEL7.4
|
@rhtyd as exchanged, for inclusion into 4.11.0.0 if there would be a 2nd RC. Thanks! |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
3 similar comments
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1659 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-2169)
|
|
Test LGTM, merging based on test results and code reviews. This PR has been accepted towards 4.11.0.0, and should make into RC2 as it fixes a libvirt domain/vm xml spec issue and may cause issue when users are using nuage integration. |
The documentation of Libvirt specifies the requirement of using an XML namespace,
when having metadata in the Domain XML. The Nuage extenstion metadata was not
adhering to this specification, and the lastest Libvirt version ignores it in that case.